Skip to content

fix(testing): use happy-dom for preloader isBrowser check#8584

Draft
maiieul wants to merge 1 commit intobuild/v2from
fix-preloader-isBrowser-variable
Draft

fix(testing): use happy-dom for preloader isBrowser check#8584
maiieul wants to merge 1 commit intobuild/v2from
fix-preloader-isBrowser-variable

Conversation

@maiieul
Copy link
Copy Markdown
Member

@maiieul maiieul commented Apr 29, 2026

What is it?

  • Bug

Description

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

Co-authored-by: Copilot <copilot@github.com>
@maiieul maiieul requested a review from a team as a code owner April 29, 2026 08:55
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 29, 2026

🦋 Changeset detected

Latest commit: 4f40f33

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maiieul maiieul self-assigned this Apr 29, 2026
@maiieul maiieul moved this to Waiting For Review in Qwik Development Apr 29, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 29, 2026

Open in StackBlitz

@qwik.dev/core

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8584

@qwik.dev/router

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8584

eslint-plugin-qwik

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8584

create-qwik

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8584

@qwik.dev/optimizer

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/optimizer@8584

commit: 4f40f33

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 4f40f33

@maiieul maiieul marked this pull request as draft April 29, 2026 18:07
@maiieul maiieul moved this from Waiting For Review to In progress in Qwik Development Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

1 participant