fix: node crash after not handled aborted connections#8613
Open
fix: node crash after not handled aborted connections#8613
Conversation
🦋 Changeset detectedLatest commit: 77a86e2 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…e the Node response stream contract
@qwik.dev/core
@qwik.dev/router
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
wmertens
approved these changes
May 7, 2026
Member
wmertens
left a comment
wmertens
left a comment
There was a problem hiding this comment.
Some nitpicks, see if you want to change those or not, LGTM
| }); | ||
| }); | ||
| let responseError: unknown; | ||
| let resolveClosed = () => {}; |
Member
There was a problem hiding this comment.
you can just do let resolveClosed: () => void, it will always be initialized
| }); | ||
| let responseError: unknown; | ||
| let resolveClosed = () => {}; | ||
| const closedPromise = new Promise<void>((resolve) => { |
Member
There was a problem hiding this comment.
you can make this = closed ? Promise.resolve() : ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were three problems:
The old code only handled messages like write after end and The stream has been destroyed.
In Node, an emitted error event without a listener can crash the process.
Other adapters resolve the response promise when the response stream is created. Node was not doing that, so handled.response could hang.