preloader: remove unused top-level timestamp initialization in constants#8644
Conversation
|
Agent-Logs-Url: https://github.com/QwikDev/qwik/sessions/9afbb8c3-ec07-4807-8c43-60ee07d1f88e Co-authored-by: wmertens <54934+wmertens@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Removes the unused top-level loadStart = performance.now() export from the preloader constants module. Eliminates an eager runtime timer read that has no consumers and can interfere with compile-time analysis tools like Wizer.
Changes:
- Delete the
loadStartexport and its// Global statecomment frompackages/qwik/src/core/preloader/constants.ts.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
@qwik.dev/core
@qwik.dev/router
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
commit: |
The preloader constants module executed a top-level
performance.now()call (loadStart) that is unused and can interfere with compile-time analysis environments (e.g. Wizer).This change removes that eager runtime access while preserving existing preloader behavior.
Problem scope
packages/qwik/src/core/preloader/constants.tsexportedloadStart = performance.now()at module load time.loadStartis not consumed anywhere in the preloader/core codepath.Change made
loadStartexport from preloader constants.Behavioral impact