Skip to content

fix(router): preserve route loader subscriptions during seq cleanup#8748

Merged
Varixo merged 1 commit into
build/v2from
v2-stale-loader-content
Jun 18, 2026
Merged

fix(router): preserve route loader subscriptions during seq cleanup#8748
Varixo merged 1 commit into
build/v2from
v2-stale-loader-content

Conversation

@Varixo

@Varixo Varixo commented Jun 18, 2026

Copy link
Copy Markdown
Member

Fixed SPA navigation in cases where route loader data could stop updating after navigating between catch-all routes. Pages now correctly re-render their content when returning through client-side navigation, including layouts that share loader data through context.

@Varixo Varixo self-assigned this Jun 18, 2026
@Varixo Varixo requested a review from a team as a code owner June 18, 2026 14:13
@Varixo Varixo added the V2 label Jun 18, 2026
@Varixo Varixo requested review from a team as code owners June 18, 2026 14:13
@changeset-bot

changeset-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e3f60bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@qwik.dev/router Patch
eslint-plugin-qwik Patch
@qwik.dev/core Patch
create-qwik Patch
@qwik.dev/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maiieul maiieul moved this from Backlog to Waiting For Review in Qwik Development Jun 18, 2026
@pkg-pr-new

pkg-pr-new Bot commented Jun 18, 2026

Copy link
Copy Markdown

Open in StackBlitz

@qwik.dev/core

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8748

@qwik.dev/router

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8748

eslint-plugin-qwik

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8748

create-qwik

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8748

@qwik.dev/optimizer

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/optimizer@8748

commit: e3f60bf

@Varixo Varixo force-pushed the v2-stale-loader-content branch from b01f045 to 4e24af5 Compare June 18, 2026 14:21
@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview b01f045

Comment thread packages/qwik/src/core/reactive-primitives/types.ts Outdated
Comment thread packages/qwik-router/src/runtime/src/qwik-router-component.tsx Outdated
@Varixo Varixo force-pushed the v2-stale-loader-content branch from 4e24af5 to 00396d5 Compare June 18, 2026 17:27

@wmertens wmertens left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦋

@Varixo Varixo force-pushed the v2-stale-loader-content branch from 00396d5 to e3f60bf Compare June 18, 2026 18:29
@Varixo Varixo merged commit d8abf22 into build/v2 Jun 18, 2026
42 of 43 checks passed
@Varixo Varixo deleted the v2-stale-loader-content branch June 18, 2026 18:54
@github-project-automation github-project-automation Bot moved this from Waiting For Review to Done in Qwik Development Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants