fix(router): honor routeLoader$ id option to avoid wrapper id collisions

[maiieul]

Overview

Loaders defined through a shared wrapper that passes an inline QRL to routeLoader$ — e.g. a withErrorHandling(fn) helper — all share a single optimizer-assigned QRL hash. Since the loader id was derived solely from that hash (loader.__id = loaderQrl.getHash()), every wrapped loader collided on the same __id, and all but the first were silently deduped away in getModuleRouteLoaders. The result: only one of the wrapped loaders ran during SSR and SPA navigation. Plain routeLoader$ calls are unaffected because each is its own lexical QRL with a distinct hash.

Changes

• Honor the id option (previously marked @deprecated Unused): loader.__id = id ?? loaderQrl.getHash(). Wrappers can now pass a stable, distinct id such as fn.getHash().
• Dev warning in getModuleRouteLoaders when two distinct loaders share the same id, so this collision surfaces loudly instead of silently dropping loaders.
• Documented the id option and added a changeset.

Notes

Surfaced while migrating a real app to Qwik v2: a routeLoaderWithErrorHandling helper wrapping routeLoader$ caused only the first loader on each route to run. The app already passed id: fn.getHash(), but the router had stopped honoring it.

I couldn't run the router unit tests in my environment; happy to add a getModuleRouteLoaders dedup/id-override test if you'd like.

[changeset-bot]

🦋 Changeset detected

Latest commit: 208628f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@qwik.dev/router	Patch
eslint-plugin-qwik	Patch
@qwik.dev/core	Patch
create-qwik	Patch
@qwik.dev/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

Open in StackBlitz

@qwik.dev/core

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8749

@qwik.dev/router

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8749

eslint-plugin-qwik

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8749

create-qwik

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8749

@qwik.dev/optimizer

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/optimizer@8749

commit: 208628f

[github-actions]

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name	Status	Preview	Last Commit
qwik-docs	✅ Ready (View Log)	Visit Preview	208628f

[wmertens]

Great! Note, maybe we're using a hash somewhere instead of loader.__id. Something to look out for.