fix(router): correctly exclude prerendered routes from the SSR plan#8759
Merged
wmertens merged 1 commit intoJun 21, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 2914d2c The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
auto-merge was automatically disabled
June 21, 2026 17:46
Head branch was pushed to by a user without write access
briancarbone
force-pushed
the
fix/exclude-prerendered-ssr-resolution
branch
from
80c1082 to
726f76e
Compare
@qwik.dev/core
@qwik.dev/router
eslint-plugin-qwik
create-qwik
@qwik.dev/optimizer
commit: |
briancarbone
force-pushed
the
fix/exclude-prerendered-ssr-resolution
branch
from
726f76e to
e346875
Compare
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
The server-route prune silently failed due to two compounding bugs, both producing an empty exclusion set: - The pruned plan used a query-suffixed virtual id (@qwik-router-config?ssr). The optimizer strips the query before resolveId runs, so the request handler resolved the full plan and isSsrConfig was never true. Use a distinct query-less id (@qwik-router-config-ssr), consistent with the other router virtual modules (@qwik-router-entries, @qwik-router-sw-register). - Server-free detection lexed raw route/layout source with es-module-lexer, which throws on JSX; the .catch fail-safe then marked every route server-bound. Swap to mlly's regex-based import/export scan, which is JSX-tolerant. Add a JSX regression case to the unit tests.
briancarbone
force-pushed
the
fix/exclude-prerendered-ssr-resolution
branch
from
e346875 to
2914d2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.