Fix #6 re: non-unique 'id' column. #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code adapted from [Advanced R](https://adv-r.hadley.nz/conditions.html#signalling), allows custom classes with errors, warnings, and messages that may be useful for future features.
Specifically, this commit: * Adds an internal function for checking whether id columns are supplied and/or valid. If no column name is supplied, row-wise ids are added quietly. If a column name is supplied but does not contain unique values for each kin-pair, a warning message states the problem and the row-wise ids will be used. * Updates `check_discord_errors()` with new id default and enhances unit-tests for this. * Updated documentation on for `discord_data()` and `discord_regression()`.
made the pair identifiers for race and sex use the pair_identifiers info
smasongarrison
approved these changes
Aug 25, 2021
smasongarrison
approved these changes
Aug 25, 2021
Member
smasongarrison
left a comment
smasongarrison
left a comment
There was a problem hiding this comment.
everything looks good (now that I've fixed what I broke with my "fixes"
Member
|
nice job |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds utility functions for discord-specific conditions, fixes #6, and updates documentation and NEWS.md.