Skip to content

chore(proto): drop pre-v1 reserved statements for Requester.billing_ref - #27

Merged
EugeneDymo merged 2 commits into
mainfrom
feature/ramp-155-remove-reserved
Jul 22, 2026
Merged

chore(proto): drop pre-v1 reserved statements for Requester.billing_ref#27
EugeneDymo merged 2 commits into
mainfrom
feature/ramp-155-remove-reserved

Conversation

@EugeneDymo

Copy link
Copy Markdown
Collaborator

Pre-v1 the wire contract is not frozen and there are no released consumers to protect, so a removed field's number returns to the free pool instead of being reserved. Matches the earlier Transaction{Request,Response} change; reserved becomes the tool for field removals once v1.0.0 is tagged.

The conformance pin keeps only the design invariant (Requester never regains a caller-written billing_ref field) and no longer freezes the field number.

…ef (RAMP-155)

Pre-v1 the wire contract is not frozen and there are no released
consumers to protect, so a removed field's number returns to the free
pool instead of being reserved. Matches the earlier
Transaction{Request,Response} change; `reserved` becomes the tool for
field removals once v1.0.0 is tagged.

The conformance pin keeps only the design invariant (Requester never
regains a caller-written billing_ref field) and no longer freezes the
field number.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@EugeneDymo
EugeneDymo requested a review from legendko July 22, 2026 10:59

@legendko legendko left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One documentation gap

website/src/content/docs/reference/changelog.mdx — stale mirror

proto/CHANGELOG.md was updated; its hand-maintained website mirror was not. reference/changelog.mdx must mirror proto/CHANGELOG.md and must be updated after meaningful proto changes.

Lines 36–37 still read (stale):

billing label on Requester is gone; field number 5 and the name are
reserved so they can never be reused with a different meaning. Nothing read

This directly contradicts the branch's own thesis and the updated proto/CHANGELOG.md, which now reads:

billing label on Requester is gone; the field is deleted outright with no
reserved statement — pre-v1 the number returns to the free pool, and
reserved becomes the tool for field removals only once v1.0.0 is tagged.
Nothing read

Fix: replace lines 36–37 of changelog.mdx with the four-line proto/CHANGELOG.md wording above (lines 53–56 there). Mechanical sync; no other divergence in that section.

…emoval

reference/changelog.mdx mirrors proto/CHANGELOG.md and still described
Requester field 5 as reserved; carry over the updated free-pool wording.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@EugeneDymo
EugeneDymo merged commit 28977f2 into main Jul 22, 2026
4 checks passed
@legendko
legendko deleted the feature/ramp-155-remove-reserved branch July 22, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants