[GRDM-59575 Workaround] BinderHubアドオン repo2docker テストに remotes を追加#40
Merged
Merged
Conversation
ec5e6ba to
9cc176a
Compare
9cc176a to
9016f79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
テスト手順-BinderHubアドオン-repo2docker.ipynb/テスト手順-BinderHub-BinderHubアドオン-repo2docker.ipynb/テスト手順-BinderHubアドオン-アドオン追加.ipynbで、解析環境ビルド時にremotesパッケージを事前に R 依存として登録しないとビルドに失敗するケースがある。各テスト手順で R パッケージを事前登録できるようにし、デフォルトにremotesを含める。Changes
テスト手順-BinderHubアドオン-repo2docker.ipynbおよびテスト手順-BinderHub-BinderHubアドオン-repo2docker.ipynbbinderhub_r_package(単一文字列)をbinderhub_r_packages(リスト)にリネームし、デフォルト値を['remotes', 'eegkit']に変更for pkg in binderhub_r_packages:ループに変更し、リスト内の各パッケージを順に登録するように修正テスト手順-BinderHubアドオン-アドオン追加.ipynbbinderhub_r_packages = ['remotes']を追加remotesを登録するように修正Ticket
Custom Test Configuration