fix: ship agents and hooks in the launch payload (iss-77)#114
Merged
Conversation
The launch-payload include list named neither the agents/ nor the hooks/ plugin-surface directory. Both exist on disk and are auto-discovered harness surfaces, yet were neither included nor explicitly excluded, so the published bundle dropped both — the plugin installed without its agents and without its hook wiring. Add "agents" and "hooks" to the payload includes, and add a bundle-completeness detector that fails when any auto-discovered plugin-surface directory present on disk is neither in the includes nor in an explicit excludes-with-reason list, so a newly-added surface can never be silently dropped again. The hooks manifest references "$CLAUDE_PLUGIN_ROOT/abcd", which resolves against the installed plugin root, so it needs no rewrite post-install. Assisted-by: Claude:claude-opus-4-8
…load-agents-hooks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The launch payload omitted agents/ and hooks/; the missing hooks/ also broke plugin-root resolution post-install. Adds both + a bundle-completeness test. ruthless: SHIP; contents confirmed free of secrets, absolute paths, and private names.
Ledger: resolves iss-77.
Assisted-by: Claude:claude-opus-4-8