chore: set dev version default to v0.8.0-dev#10
Merged
Conversation
The in-tree version var is only the fallback for untagged local builds; releases inject the git tag via -ldflags. It was stale at v0.4.0-dev. v0.7.3 has shipped, so the line in progress is v0.8.0 — report v0.8.0-dev, and update the release how-to's example to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the in-tree
versiondefault incmd/root.gofrom the stalev0.4.0-devto
v0.8.0-dev— the line now in progress (v0.7.3 has shipped).This var is only the fallback for untagged local builds; releases inject the
tag via
-ldflags, and the-devsuffix marks a build as not a tagged release.It had drifted far behind the actual release line. Also updates the matching
example in
docs/how-to/cutting-a-release.md.Verified:
make build,gofmt -l .,go vet ./..., andgo test ./cmd/clean;the built binary reports
ferry v0.8.0-dev.