A review flagged the 1/(4pi) in calculate_trp as an 11 dB bug. It is NOT — the per-angle input is EIRP and (1/4pi) Sum EIRP*sin(theta)*dtheta*dphi is the canonical CTIA/IEEE-149 discrete TRP. Verified: an isotropic 0 dBm EIRP pattern integrates to -0.003 dBm. Docstring clarified to prevent future false alarms.
Acceptance criteria
- Docstring states the input is EIRP and the 1/(4pi) rationale. (Done — closed by the accompanying commit.)
Ref: plot_antenna/calculations.py:7-39. (R7)
A review flagged the
1/(4pi)incalculate_trpas an 11 dB bug. It is NOT — the per-angle input is EIRP and(1/4pi) Sum EIRP*sin(theta)*dtheta*dphiis the canonical CTIA/IEEE-149 discrete TRP. Verified: an isotropic 0 dBm EIRP pattern integrates to -0.003 dBm. Docstring clarified to prevent future false alarms.Acceptance criteria
Ref:
plot_antenna/calculations.py:7-39. (R7)