list_transfers to take an AssetFilter and an optional txid - #97
Merged
zoedberg merged 1 commit intoAug 10, 2026
Merged
Conversation
dcorral
marked this pull request as draft
August 6, 2026 12:07
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #97 +/- ##
=======================================
Coverage 96.23% 96.24%
=======================================
Files 24 24
Lines 13396 13418 +22
=======================================
+ Hits 12892 12914 +22
Misses 504 504
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dcorral
force-pushed
the
upstream-list-transfers-filter
branch
from
August 6, 2026 12:09
1d69856 to
b82342b
Compare
dcorral
marked this pull request as ready for review
August 6, 2026 12:21
zoedberg
requested changes
Aug 6, 2026
zoedberg
left a comment
Member
There was a problem hiding this comment.
Thanks! Please address the requested changes
dcorral
force-pushed
the
upstream-list-transfers-filter
branch
2 times, most recently
from
August 7, 2026 09:51
ed45764 to
768842c
Compare
zoedberg
requested changes
Aug 7, 2026
dcorral
force-pushed
the
upstream-list-transfers-filter
branch
2 times, most recently
from
August 8, 2026 13:52
6e46c17 to
4778316
Compare
zoedberg
requested changes
Aug 8, 2026
zoedberg
left a comment
Member
There was a problem hiding this comment.
let's use db_data, to avoid the extra query
note that this change will make you revert the ones you did to src/database/mod.rs
dcorral
force-pushed
the
upstream-list-transfers-filter
branch
from
August 10, 2026 09:48
4778316 to
ecb9842
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change to list_transfers, replacing the asset_id: Option parameter (where None meant "transfers not connected to a specific asset") with two explicit parameters:
This makes it possible to look up the transfers behind a given on-chain transaction without listing per asset and filtering client-side.