Skip to content

fix: Renamed CLAUDE.md to AGENTS.md#122

Merged
dmartinol merged 1 commit into
RHEcosystemAppEng:mainfrom
dmartinol:feat/pack-agents-md-issue-121
Jun 17, 2026
Merged

fix: Renamed CLAUDE.md to AGENTS.md#122
dmartinol merged 1 commit into
RHEcosystemAppEng:mainfrom
dmartinol:feat/pack-agents-md-issue-121

Conversation

@dmartinol

Copy link
Copy Markdown
Collaborator

Summary

Fix #121

Pack(s) affected

  • Other / repo-wide

Change type

  • Update existing skill / agent
  • Docs / README
  • CI / tooling

Validation

  • make validate passes locally

@dmartinol dmartinol requested a review from TomerFi June 16, 2026 15:38
@TomerFi

TomerFi commented Jun 16, 2026

Copy link
Copy Markdown
Member

This rename is the right move — lola only picks up AGENTS.md, so our packs' instruction files are invisible to it today.

One concern: with current lola behavior, once we ship AGENTS.md in our packs, lola install will silently inject that content into users' instruction files with no opt-out. This is the exact problem tracked in LobsterTrap/lola#148 and LobsterTrap/lola#158, with a fix in progress at LobsterTrap/lola#159 (--no-instructions / --overwrite flags).

That PR still has unresolved review feedback and hasn't seen activity since June 1, so I wouldn't block on it. Users can already use --append-context for lighter-touch installs, and once #159 lands the experience improves further.

I'd suggest we merge this but call out the lola dependency in the description or a follow-up issue — something like "if you prefer lola not manage your instruction files, use --append-context until lola adds --no-instructions support."

Everything looks clean — the renames are content-identical, root CLAUDE.md is correctly untouched, validate_structure.py now rejects deprecated pack-level CLAUDE.md, and the workflow/catalog/scripts are all updated.

@dmartinol dmartinol merged commit 41550fc into RHEcosystemAppEng:main Jun 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Module level CLAUDE.md is not managed by Lola

2 participants