Skip to content

Rh virt/skill refactor linter#23

Merged
dmartinol merged 9 commits into
RHEcosystemAppEng:mainfrom
r2dedios:rh-virt/skill-refactor-linter
Mar 3, 2026
Merged

Rh virt/skill refactor linter#23
dmartinol merged 9 commits into
RHEcosystemAppEng:mainfrom
r2dedios:rh-virt/skill-refactor-linter

Conversation

@r2dedios

@r2dedios r2dedios commented Mar 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Pack(s) affected

  • rh-sre
  • rh-developer
  • ocp-admin
  • rh-support-engineer
  • rh-virt
  • Other / repo-wide

Change type

  • New skill
  • New agent
  • New pack
  • Update existing skill / agent
  • MCP server config (.mcp.json)
  • Docs / README
  • CI / tooling

CLAUDE.md compliance

  • Agents orchestrate skills; no direct MCP/tool calls in agents
  • Skills are single-purpose task executors
  • Skills encapsulate all tool access (MCP tools invoked only inside skills)
  • Document consultation: file is read with the Read tool, then declared to the user
  • No credentials hardcoded; env vars used via ${VAR} references
  • Human-in-the-loop confirmation added for any destructive or critical operations

Validation

  • make validate passes locally
  • New/changed skills have valid YAML frontmatter (name, description)
  • New/changed agents have valid YAML frontmatter (name, description)

r2dedios added 9 commits March 2, 2026 16:24
@r2dedios
fix(rh-virt): Refactored vm-snapshot-restore skill to match linter re…
b42f11f 
…quirements

Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
@r2dedios
fix(rh-virt): Refactored vm-snapshot-create skill to match linter req…
b8ed8b3 
…uirements

Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
@r2dedios
fix(rh-virt): Refactored vm-clone skill to match linter requirements
017a997 
Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
@r2dedios
fix(rh-virt): Refactored vm-create skill to match linter requirements
6125f6f 
Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
@r2dedios
fix(rh-virt): Refactored vm-delete skill to match linter requirements
1924dad 
Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
@r2dedios
fix(rh-virt): Refactored vm-inventory skill to match linter requirements
7827f68 
Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
@r2dedios
fix(rh-virt): Refactored vm-lifecycle skill to match linter requirements
4741bd1 
Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
@r2dedios
fix(rh-virt): Refactored vm-rebalance skill to match linter requirements
1e355f4 
Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
@r2dedios
chore(ci): Added Warning report details to skill linter script
a23bf64 
Signed-off-by: r2dedios <alex.ansi.c@gmail.com>
@r2dedios r2dedios requested review from dmartinol and ikrispin March 3, 2026 14:33
@r2dedios r2dedios self-assigned this Mar 3, 2026
@r2dedios r2dedios added the enhancement New feature or request label Mar 3, 2026
@r2dedios

r2dedios commented Mar 3, 2026

Copy link
Copy Markdown
Contributor Author

Solving some errors reported by make validate-skill-design

dmartinol
dmartinol approved these changes Mar 3, 2026
View reviewed changes

@dmartinol dmartinol left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! /lgtm

@dmartinol dmartinol merged commit 10224dc into RHEcosystemAppEng:main Mar 3, 2026
2 checks passed
TomerFi pushed a commit to TomerFi/agentic-plugins that referenced this pull request May 20, 2026
@GuyZivRH @cursoragent
feat: add evaluation reports for 5 positive-diff skills
558f06f 
New reports (4):
- ocp-admin/cluster-report (+0.6364, PR RHEcosystemAppEng#3)
- rh-ai-engineer/ds-project-setup (+0.6667, PR RHEcosystemAppEng#51)
- rh-basic/red-hat-support-severity (+0.1111, PR RHEcosystemAppEng#35)
- rh-sre/cve-validation (+0.2222, PR RHEcosystemAppEng#23)

Updated (1):
- rh-virt/vm-lifecycle-manager (+0.3889, PR RHEcosystemAppEng#18)

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmartinol dmartinol dmartinol approved these changes
@ikrispin ikrispin Awaiting requested review from ikrispin

Assignees

@r2dedios r2dedios

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@r2dedios @dmartinol