fix:Clean exclusions to enable repeated runs#153
Merged
Conversation
zvigrinberg
reviewed
Dec 1, 2025
| found_package = False | ||
| matching_documents = [] | ||
| for dependency in self.tree_dict.values(): | ||
| if dependency[EXCLUSIONS_INDEX]: |
Collaborator
There was a problem hiding this comment.
@TamarW0 Why do you need here an if statement?
The following code in constructor guarantees that the exclusions index exists and contain at least empty least
https://github.com/RHEcosystemAppEng/vulnerability-analysis/blob/cf30e77497a466c477a6debb7bf74813f86096d5/src/vuln_analysis/utils/chain_of_calls_retriever.py#L88-L92
On the other hand, it's safer this way.
Collaborator
Author
There was a problem hiding this comment.
you are right
it was for debugging, removed
zvigrinberg
approved these changes
Dec 3, 2025
zvigrinberg
left a comment
zvigrinberg
left a comment
Collaborator
There was a problem hiding this comment.
@TamarW0 LGTM, Approved.
Thanks!.
heatherzh01
pushed a commit
that referenced
this pull request
Mar 6, 2026
fix:Clean exclusions to enable repeated runs --------- Co-authored-by: Tamar Weisskopf <tweissko@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.