Merged
Conversation
Signed-off-by: Ruben Romero Montes <rromerom@redhat.com>
ruromero
force-pushed
the
remove-log-utils
branch
from
eb0af50 to
dd4768f
Compare
bmozaffa
approved these changes
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #110
Related to #111
The Logger utils were imported from the kie-cloud-operator when the controller-runtime (v0.1.8) didn't provide and after an upgrade to the newer SDK (v0.3.0) it seemed to be required.
That doesn't seem to be the case anymore as the controller-runtime provides a proper logging framework. Besides, in order to remove duplicity and further configuration conflicts or confusion it seems reasonable to just remove the Logger utils from this library.