Add Cupy as optional dep and as FFTFilter#16
Conversation
|
Converted to draft. Please ping me when you need a review 👍 |
|
@paulmueller please review this, when you have time. :) |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
+ Coverage 85.75% 87.42% +1.67%
==========================================
Files 11 13 +2
Lines 400 525 +125
==========================================
+ Hits 343 459 +116
- Misses 57 66 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @paulmueller I made the changes you requested. Check out the new ci matrix. I added a relatively nice way of formatting it. Do you think we need the optional dep to be individually tested also? It baloons the number of jobs. |
|
IMO optional dependencies do not need to be tested individually. |
Great
I assumed that 3.14 would work fine. But you know what they say when you assume...
There is none. I will remove the extra with a comment explaining why @paulmueller looks like this is ready. I removed 3.14, as packages such as cupy and scikit-image do not yet have wheels for it. |



As described in #10, it would be good to have a gpu implementation built in as an FFTFilter.
A lot of this was done in #8, but we have split that up into #9 and here #16.
Todos