Skip to content

Added Vec3 with essential functionality#25

Merged
tarehart merged 10 commits into
masterfrom
vec3
Jul 3, 2019
Merged

Added Vec3 with essential functionality#25
tarehart merged 10 commits into
masterfrom
vec3

Conversation

@NicEastvillage

Copy link
Copy Markdown
Contributor

This Vec3 contains the most important functionality of vectors. It is added due to a discussion in #python.

  • Novice programmers sometimes knows little about linear algebra. With this they don't have to implement their own with no knowledge of vectors.
  • It gives a great example of how to use classes and it leaves room for extensions.
  • Python-RLU is not supported anymore (or is hard to setup).

The PR also contains an Orientation class. This is included since forward-, right-, and up- vectors of the car as well as relative coordinates are so useful.

@NicEastvillage NicEastvillage requested a review from tarehart July 3, 2019 09:21
Comment thread python_example/util/orientation.py Outdated
Comment thread python_example/util/vec.py Outdated
Comment thread python_example/util/vec.py
Comment thread python_example/util/orientation.py Outdated

@tarehart tarehart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread python_example/util/orientation.py Outdated
Comment thread python_example/util/vec.py Outdated
Comment thread python_example/util/vec.py Outdated
@NicEastvillage

Copy link
Copy Markdown
Contributor Author

The bot wiggles after the ball as normal, but I just wanna do a quick extra test before you merge.

@NicEastvillage

Copy link
Copy Markdown
Contributor Author

Okay. Everything is tested now. Ready for merge.

@tarehart tarehart merged commit 5777fca into master Jul 3, 2019
@tarehart tarehart deleted the vec3 branch July 3, 2019 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants