Skip to content

Fix: sam3 rpc - #131

Merged
qurakchin merged 1 commit into
RLinf:mainfrom
6UOOON9:fix/pi05-dtype-and-sam3-rpc
Aug 31, 2026
Merged

Fix: sam3 rpc#131
qurakchin merged 1 commit into
RLinf:mainfrom
6UOOON9:fix/pi05-dtype-and-sam3-rpc

Conversation

@6UOOON9

@6UOOON9 6UOOON9 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR fixes the bug:

SAM3 RPC readiness fails because Sam3Facade._dispatch() bypasses the base RpcFacade handling of lifecycle methods such as healthz.

Problem

Sam3Facade._dispatch() only handled segment and raised directly for every other method. After RPC lifecycle handling was lifted into RpcFacade, this bypassed the base implementation. As a result, healthz returned:

unknown RPC method: 'healthz'

Dashboard readiness checks therefore never succeeded, causing the session to wait for 300 seconds and enter a fatal state. Since env_server is task-scoped and starts after shared services become ready, it was never spawned.

Fix

  • Change the SAM3 dispatch fallback from raising an error to calling super()._dispatch().
  • This restores base lifecycle methods such as healthz and shutdown.
  • Existing segment behavior is unchanged.

Testing

SAM3 server starts successfully.

@wilburx813 wilburx813 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! The fix for Bug 2 looks great.
For Bug 1, I think it would be better fixed upstream in https://github.com/RLinf/openpi/tree/rpent, rather than monkey-patch in RPent. Would you be willing to open a pr there? If you don’t have the bandwidth, please let us know and we can take it over.

@6UOOON9

6UOOON9 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

Thanks so much for the review! I'm glad the fix for Bug 2 looks good.

I also agree that fixing Bug 1 upstream in RLinf/openpi would be the better approach, since it addresses the dtype mismatch at its source rather than monkey-patching it in RPent. Unfortunately, I'm not very familiar with the OpenPI codebase yet, so I'd appreciate it if you could take it over. Please feel free to adapt or reuse the patch there if helpful.

Thank you again for maintaining such an excellent project!

@wilburx813

Copy link
Copy Markdown
Collaborator

Thanks so much for the review! I'm glad the fix for Bug 2 looks good.

I also agree that fixing Bug 1 upstream in RLinf/openpi would be the better approach, since it addresses the dtype mismatch at its source rather than monkey-patching it in RPent. Unfortunately, I'm not very familiar with the OpenPI codebase yet, so I'd appreciate it if you could take it over. Please feel free to adapt or reuse the patch there if helpful.

Thank you again for maintaining such an excellent project!

Thanks for your understading, we’ll take over the bug1 fix in upstream. could you please keep this pr focused on bug2? Thanks again for your contribution!

@6UOOON9
6UOOON9 force-pushed the fix/pi05-dtype-and-sam3-rpc branch from 2320fa0 to 8d53f88 Compare August 31, 2026 07:36
@6UOOON9 6UOOON9 changed the title Fix/pi05 dtype and sam3 rpc Fix: sam3 rpc Aug 31, 2026
@QuanluZhang
QuanluZhang requested a review from qurakchin August 31, 2026 08:16
@qurakchin
qurakchin merged commit 202a658 into RLinf:main Aug 31, 2026
1 check passed
@qurakchin

Copy link
Copy Markdown
Collaborator

Thanks for your contribution!

@6UOOON9
6UOOON9 deleted the fix/pi05-dtype-and-sam3-rpc branch September 1, 2026 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants