Skip to content

Stabilize ROS2 integration CI checks#4

Open
RN0H wants to merge 4 commits intomasterfrom
codex/fix-failing-ros2-integration-test
Open

Stabilize ROS2 integration CI checks#4
RN0H wants to merge 4 commits intomasterfrom
codex/fix-failing-ros2-integration-test

Conversation

@RN0H
Copy link
Copy Markdown
Owner

@RN0H RN0H commented Mar 14, 2026

Motivation

  • Integration CI was brittle due to missing host dependencies (e.g. jq) and provided little diagnostics when the ROS2 demo container failed to start.
  • Improving failure visibility and ensuring required tools are present will make CI failures actionable and easier to triage.

Description

  • Install jq in the integration job by adding an apt-get install -y jq step to .github/workflows/sanity.yml.
  • Add a print_debug_info helper to tests/integration.sh that prints docker ps output and container logs to aid debugging.
  • Fail fast if the demo container is not running immediately after docker run, and call print_debug_info when the /talker node does not appear within the wait window.

Testing

  • Ran ./tests/sanity.sh, which executed package tests and make build, and it passed.
  • Performed syntax checks with bash -n tests/integration.sh and bash -n tests/sanity.sh, both of which passed.
  • Executing bash -x ./tests/integration.sh failed in this environment because docker is not installed, which is expected outside a Docker-capable CI runner.

Codex Task

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant