Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ros2subcommand from stalling the whole graph collection by using per-command timeouts.Description
graphCommandTimeout(default 10s) and a helperrunGraphCommandthat wraps eachros2invocation with its own timeout and replace previous shared timeout usage inCollectSystemGraph.CollectSystemGraphby returning errors whenros2 topic listorros2 service listfail.tests/integration.shby using unique container names, stronger container readiness checks, retryinggim graphwith JSON validation viajq, adding debug output on failure, silencing/remove-stale-container calls, and settingGIMBLE_AI_API_KEY=when runninggim analyze.graph_errors_test.goandgraph_timeout_test.go) to validate error propagation and per-command timeout behavior inCollectSystemGraph..github/workflows/sanity.ymlto installjqin theintegrationjob so the script's JSON checks work.Testing
go test ./internal/ros, which executedTestCollectSystemGraph_UsesPerCommandTimeoutand the error tests and they passed../tests/integration.sh(as used by the CIintegrationjob) withjqavailable and the script completed successfully in CI.make buildand thegim graph ros2/gim analyze ros2flow in the integration script path during the integration run and observed expected JSON output.Codex Task