Do i need Visual Studio and Extensions like C++ etc.

[Tpal12]

Since I couldn't find a definitive answer, I'm asking directly.
I'm using RocM/Hip 7.13 from this repository:
https://rocm.devreleases.amd.com/v2-staging/gfx103X-dgpu/

The installation was done with pip install --index-url https://rocm.devreleases.amd.com/v2-staging/gfx103X-dgpu/ rocm rocm-sdk-core rocm-sdk-devel rocm-sdk-libraries-gfx103x-dgpu torch torchaudio torchvision.

In my directory venv\Lib\site-packages\_rocm_sdk_devel\lib\llvm\bin are files like amdclang.exe, amdclang++.exe, etc. Therefore, I'm wondering if I still need Visual Studio + C++ make tools, MSCV Windows SDK´s and such

Thank you very much! Regarding

[ScottTodd]

It depends on what you want to do with the installed packages. I believe there is some code in pytorch for certain features that expects to be able to run cl.exe (MSVC / Visual Studio). The core ROCm packages should not need a separate Visual Studio install to work though.

[Tpal12]

Thanks for the quick reply

I'm running primarily Comfyui
in my start .bat i have some magic like:

rocm-sdk init
:: Get ROCm paths from rocm-sdk
for /f "delims=" %%i in ('rocm-sdk path --root') do set ROCM_ROOT=%%i
for /f "delims=" %%i in ('rocm-sdk path --bin') do set ROCM_BIN=%%i
:: set ROCm environment variables
set ROCM_HOME=%ROCM_ROOT%
set PATH=%ROCM_ROOT%\lib\llvm\bin;%ROCM_BIN%;%PATH%
set HIP_PATH=%ROCM_ROOT%
set HIP_PATH_71=%ROCM_ROOT%\bin
set HIP_PATH_72=%ROCM_ROOT%\bin
set HIP_CLANG_PATH=%ROCM_ROOT%\lib\llvm\bin
set HIP_LIB_PATH=%ROCM_ROOT%\lib
::set "LD_LIBRARY_PATH=%ROCM_ROOT%\lib_rocm_sdk_libraries_gfx103X_dgpu\bin"
:: linker für Triton rocm integration !!!TESTEN und im zweifel auskommentieren!!!
set DEVICE_LIB_PATH=%ROCM_ROOT%\lib\llvm\amdgcn\bitcode
set HIP_DEVICE_LIB_PATH=%ROCM_ROOT%\lib\llvm\amdgcn\bitcode
::set "LIBRARY_PATH=%ROCM_ROOT%\lib_rocm_sdk_libraries_gfx103X_dgpu\bin"
::set LIBRARY_PATH=%HIP_LIB_PATH%;%ROCM_PATH%\lib;%ROCM_PATH%\lib;%LIBRARY_PATH%
set HIP_INCLUDE_PATH=%ROCM_ROOT%\include
:: Set compiler to clang-cl for AMD ROCm compatibility
set CC=clang-cl
set CXX=clang-cl
set DISTUTILS_USE_SDK=1

so if i set this flags i need msvc buildtools?

set CC=clang-cl

set CXX=clang-cl

[ScottTodd]

If you use the packages produced by TheRock, I don't believe you should need any of those additional options to run comfyui python, see:

• https://rocm.docs.amd.com/en/7.12.0-preview/rocm-for-ai/comfyui.html
• https://rocm.docs.amd.com/en/7.11.0-preview/rocm-for-ai/pytorch-comfyui.html

In my own testing I do roughly what's in those docs:

py -3.12 -m venv .venv
.venv\Scripts\activate
python -m pip install --index-url https://repo.amd.com/rocm/whl/gfx110X-all/ torch torchvision torchaudio

git clone https://github.com/comfyanonymous/ComfyUI.git
pip install -r ComfyUI\requirements.txt
python ComfyUI\main.py

(with no additional environment variables, though I do usually have Visual Studio Build Tools installed and on my PATH, fwiw)

[Tpal12]

That's fantastic news!
I was using Zluda and needed it to compile for my not-so-well-supported RX 6700 XT. Thanks to this project, it´s time to free up disk space
I dared to uninstall it ^^ it's still working.

Thank you so much for your support/encouragement, and all the best!

[Tpal12]

Ahh sadge for new convolutions with MiOpen i need MSVC

[astrelsky]

I think you still need to meet the requirements for using clang on Windows if you are compiling code that runs on Windows (as opposed to the GPU). I think you only need the windows sdk, because clang does not provide the headers and libraries, why would it anyway. It is it's own compiler and doesn't need cl at all afaik.

I never use msvc on windows, I always just use clang and let it do it. I usually just install the build tools and avoid the visual studio ide like the plague.

[Tpal12]

You´re right, after some testing i can confirm only Build Tools 2022 C++ in my case -> MSCV V143 and Windows 11 SDK is needed

[AznamirWoW]

Can someone tell me what am I missing

MIOpen(HIP): Error [Compile] 'hiprtcCompileProgram(prog.get(), c_options.size(), c_options.data())' MIOpenBatchNormFwdInferSpatial.cpp: HIPRTC_ERROR_COMPILATION (6)
MIOpen(HIP): Error [BuildHip] HIPRTC status = HIPRTC_ERROR_COMPILATION (6), source file: MIOpenBatchNormFwdInferSpatial.cpp
MIOpen(HIP): Warning [BuildHip] In file included from C:\Users\user\AppData\Local\Temp\comgr-1204-37-85a39d\input\MIOpenBatchNormFwdInferSpatial.cpp:30:
In file included from C:\Users\user\AppData\Local\Temp\comgr-1204-37-85a39d\include\bnorm_spatial_activation_functions.hpp:32:
In file included from C:\Users\user\AppData\Local\Temp\comgr-1204-37-85a39d\include\configuration.hpp:34:
In file included from C:\Users\user\AppData\Local\Temp\comgr-1204-37-85a39d\include\vector_types.hpp:8:
C:\Users\user\AppData\Local\Temp\comgr-1204-37-85a39d\include\miopen_type_traits.hpp:151:10: fatal error: 'type_traits' file not found
151 | #include <type_traits>
| ^~~~~~~~~~~~~
1 error generated when compiling for gfx1031.
MIOpen Error: DESKTOP-1MFPGB0:C:/home/runner/_work/TheRock/TheRock/rocm-libraries/projects/miopen/src/hipoc/hipoc_program.cpp:299: Code object build failed. Source: MIOpenBatchNormFwdInferSpatial.cpp

[astrelsky]

Can someone tell me what am I missing

MIOpen(HIP): Error [Compile] 'hiprtcCompileProgram(prog.get(), c_options.size(), c_options.data())' MIOpenBatchNormFwdInferSpatial.cpp: HIPRTC_ERROR_COMPILATION (6)
MIOpen(HIP): Error [BuildHip] HIPRTC status = HIPRTC_ERROR_COMPILATION (6), source file: MIOpenBatchNormFwdInferSpatial.cpp
MIOpen(HIP): Warning [BuildHip] In file included from C:\Users\user\AppData\Local\Temp\comgr-1204-37-85a39d\input\MIOpenBatchNormFwdInferSpatial.cpp:30:
In file included from C:\Users\user\AppData\Local\Temp\comgr-1204-37-85a39d\include\bnorm_spatial_activation_functions.hpp:32:
In file included from C:\Users\user\AppData\Local\Temp\comgr-1204-37-85a39d\include\configuration.hpp:34:
In file included from C:\Users\user\AppData\Local\Temp\comgr-1204-37-85a39d\include\vector_types.hpp:8:
C:\Users\user\AppData\Local\Temp\comgr-1204-37-85a39d\include\miopen_type_traits.hpp:151:10: fatal error: 'type_traits' file not found
151 | #include <type_traits>
| ^~~~~~~~~~~~~
1 error generated when compiling for gfx1031.
MIOpen Error: DESKTOP-1MFPGB0:C:/home/runner/_work/TheRock/TheRock/rocm-libraries/projects/miopen/src/hipoc/hipoc_program.cpp:299: Code object build failed. Source: MIOpenBatchNormFwdInferSpatial.cpp