Fix for using byte offsets with DMA executors#330
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates TransferBench to correctly apply non-zero data.byteOffset when performing DMA executor copies, ensuring the configured offset is reflected in the source/destination addresses used by the DMA copy paths.
Changes:
- Bump core version from
1.68to1.69and add a v1.69.00 changelog entry. - Apply
cfg.data.byteOffsetto both SRC and DST pointers used in DMA executor copy calls (HIP/CUDA memcpy and HSA async copy).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/header/TransferBench.hpp | Applies byteOffset to DMA executor SRC/DST pointers and bumps VERSION to 1.69. |
| src/client/Client.cpp | Modifies the printed version banner string. |
| CHANGELOG.md | Adds v1.69.00 entry documenting the DMA byte-offset fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nileshnegi
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Non-zero byte-offsets were not being properly handled by the DMA executor