HipKittens MXFP8 GEMM Support#566
Merged
Merged
Conversation
alextmagro
requested review from
ipanfilo,
wangye805 and
wenchenvincent
as code owners
April 28, 2026 05:16
wangye805
requested changes
May 1, 2026
aris134
reviewed
May 6, 2026
aris134
reviewed
May 6, 2026
aris134
reviewed
May 6, 2026
aris134
reviewed
May 6, 2026
ipanfilo
requested changes
May 8, 2026
ipanfilo
reviewed
May 29, 2026
ipanfilo
reviewed
Jun 4, 2026
ipanfilo
reviewed
Jun 18, 2026
ipanfilo
reviewed
Jun 19, 2026
ipanfilo
left a comment
ipanfilo
left a comment
Collaborator
There was a problem hiding this comment.
Some comments in rocm_gemm and test_cublas_gemm are still open
ipanfilo
reviewed
Jun 22, 2026
ipanfilo
left a comment
ipanfilo
left a comment
Collaborator
There was a problem hiding this comment.
The remaining open question is WS size calculation for JAX
| n = reduce(operator.mul, rhs_non_contracting_shape) | ||
| k = lhs_contracting_size | ||
| layout = ("T" if lhs_is_transposed else "N") + ("T" if rhs_is_transposed else "N") | ||
| workspace_size = max(workspace_size, |
Collaborator
There was a problem hiding this comment.
Original MXFP8 workspace_size here consist of hipblasLt requirements + optional pre-swizzling WS on gfx1250, why are they honored in hipKittens case?
Is pre-swizzling applied when hipKittens is enabled (ignoring the fact that they are for different archs)?
Contributor
Author
There was a problem hiding this comment.
hipKittens does not use pre-swizzling, this issue was introduced during a dev merge, should be fixed now.
ipanfilo
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates an MXFP8 GEMM with HipKittens that outperforms hipBLASlt, and offers additional epilogues such as BIAS and GELU AUX
Requires a workspace sized relative to the model. Often larger than hipBLASlt, but with significant performance improvements. Only builds for gfx950, and requires M / 256 and N / 256.
Adds hipKittens header library as a submodule.