MLA PS mode fp8 -n 16,3 16,4 and nhead=32,64,128 support cp round robin - #4521
Merged
Conversation
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends gfx950 MLA persistent (PS) FP8 support to additional decode qlen/head-count combinations and adds CP round-robin (interleaved KV) coverage, including wiring new asm kernel entries and updating routing/metadata to recognize the new supported shapes.
Changes:
- Broaden gfx950 FP8/F8 PS decode support gating (incl. nhead 32/64/128) and add qlen=3 handling in metadata/dispatch.
- Add CP round-robin FP8 test support by threading explicit unit
q_scale/kv_scaleinto the test harness and enabling fp8/fp8 runs. - Update gfx950 MLA asm kernel registry CSV with new CP round-robin kernel variants and remove superseded entries.
Reviewed changes
Copilot reviewed 7 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| op_tests/test_mla_persistent.py | Updates PS-mode support gating for gfx950 fp8/fp8 head-count cases. |
| op_tests/test_mla_persistent_round_robin.py | Enables fp8/fp8 CP round-robin testing and threads q/kv scales. |
| hsa/gfx950/mla/mla_asm.csv | Registers new gfx950 FP8 CP round-robin asm kernels and removes old entries. |
| csrc/py_itfs_cu/asm_mla.cu | Adjusts gfx950 FP8 dispatch heuristics (incl. qlen=3) and kernel selection. |
| csrc/kernels/mla/metadata/v1_2_device.cuh | Broadens native-support gating and adds packed-QoLen special-case for qlen=3. |
| aiter/ops/attention.py | Aligns metadata selection logic for gfx950 fp8/fp8 qlen=3 and minor comment edits. |
| aiter/mla.py | Broadens gfx950 fp8/fp8 PS-mode support gating (nhead 32/64/128). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 task
minmengdie
force-pushed
the
mmd/dev/mla_fp8_cp_round_robin
branch
from
August 5, 2026 10:16
cb823af to
0cbedbb
Compare
shengnxu
approved these changes
Aug 6, 2026
12 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR extends gfx950 MLA persistent (PS) FP8 support to additional decode qlen/head-count combinations and adds CP round-robin (interleaved KV) coverage, including wiring new asm kernel entries and updating routing/metadata to recognize the new supported shapes.
Technical Details
Broaden gfx950 FP8/F8 PS decode support gating (incl. nhead 32/64/128) and add qlen=3 handling in metadata/dispatch.
Add CP round-robin FP8 test support by threading explicit unit q_scale/kv_scale into the test harness and enabling fp8/fp8 runs.
Update gfx950 MLA asm kernel registry CSV with new CP round-robin kernel variants and remove superseded entries.
Test Plan
python3 op_tests/test_mla_persistent_round_robin.py -d fp8 -kvd fp8 -lse
python3 op_tests/test_mla_persistent.py -d fp8 -kvd fp8 -lse -n 16,3 16,4 16,6 32,2 32,3 32,4 64,1 64,2 64,3 128,1 128,2 -b 32 64 128 -c 1024 5000 8192 16384
Test Result
has_NaN=Truecal_diffhard gate)Submission Checklist