Skip to content

[FLYDSL] Fix GDR reductions for FlyDSL 0.2.4 - #4540

Open
IzacharyI wants to merge 2 commits into
ROCm:Qwen3.5_devfrom
IzacharyI:Fixed_decode_GDR_in_flydsl_0_2_4
Open

[FLYDSL] Fix GDR reductions for FlyDSL 0.2.4#4540
IzacharyI wants to merge 2 commits into
ROCm:Qwen3.5_devfrom
IzacharyI:Fixed_decode_GDR_in_flydsl_0_2_4

Conversation

@IzacharyI

@IzacharyI IzacharyI commented Aug 4, 2026

Copy link
Copy Markdown
Use raw MLIR vector operations so Qwen3.5 GDR decode compiles with the upgraded FlyDSL API.

Motivation

After upgrading the Qwen3.5 development branch to FlyDSL 0.2.4, GDR decode fails during cold kernel compilation:

TypeError: EnumMeta.__call__() takes from 2 to 3 positional arguments but 4 were given
FlyDSL 0.2.4 changed flydsl.expr.vector.ReductionOp into an expression enum, while the GDR kernel still invoked it as a raw MLIR operation. This prevents Qwen3.5-27B TP1 FlyDSL decode and CUDA Graph capture from starting.

Modifications

  • Use the raw MLIR vector dialect for GDR reduction operations.
  • Convert DSL vector values with _to_raw.
  • Fix Q/K normalization and hidden-state reduction sites.

Technical Details

Test Plan

image

Test Result

Submission Checklist

    Use raw MLIR vector operations so Qwen3.5 GDR decode compiles with the upgraded FlyDSL API.
@zufayu
zufayu requested a review from yadaish August 5, 2026 01:40
    Bring PR ROCm#3135's stride-aware VK kernel and tuned configs to FlyDSL 0.2.4, with parity and graph replay coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant