[rocm7.2] Drop missing cp313-cp313t from setuptools/wheel install loop#105
Open
JeniferC99 wants to merge 1 commit into
Open
[rocm7.2] Drop missing cp313-cp313t from setuptools/wheel install loop#105JeniferC99 wants to merge 1 commit into
JeniferC99 wants to merge 1 commit into
Conversation
The pinned manylinux_2_28_x86_64 base image
(sha256:2147aade9cc6f841c9b610ec7b033299b09e425cd3a652bdf1cb9fc885f86078)
no longer ships /opt/python/cp313-cp313t/. The free-threaded interpreter
moved up with CPython and is now distributed as cp314-cp314t /
cp315-cp315t. Iterating over cp313-cp313t in this RUN therefore aborts
the docker build with exit code 127 ("command not found"), which is what
took down the py3.13 branch in pytorch-manylinux-wheel-builder pytorch#511,
pytorch#512, pytorch#513, pytorch#514 (parents pytorch2.10 #61, pytorch2.8 #84, pytorch2.7
#87, pytorch2.9 pytorch#151) under LKG_BUILD_NUM=93.
Drop cp313-cp313t from the loop. None of the pytorch wheel matrices in
this repo reference 3.13t, so this only removes a no-longer-available
target. The cp312/cp313 entries cover the actual python versions we
build (3.10/3.11/3.12/3.13 are exercised by the wheel jobs; 3.10/3.11
already ship setuptools/wheel by default).
Verified locally: docker build of the patched RUN against the same
pinned base digest now completes successfully.
Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Pull request overview
Fixes the manylinux wheel builder Docker image setup step that fails in the Python 3.13 CI branch due to attempting to run a non-existent interpreter path (/opt/python/cp313-cp313t/bin/python) in the setuptools/wheel install loop.
Changes:
- Removed
cp313-cp313tfrom the/opt/python/...interpreter loop to preventexit code 127during Docker builds. - Added an inline comment explaining why
cp313-cp313tis not present in the upstream manylinux 2_28 image (and where free-threaded builds now live).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
manywheel/Dockerfile_2_28aborts every wheel build at step 18:The pinned base image
quay.io/pypa/manylinux_2_28_x86_64@sha256:2147aade9c…no longer ships/opt/python/cp313-cp313t/— free-threaded moved up tocp314-cp314t/cp315-cp315twith CPython.What
Drop
cp313-cp313tfrom the loop. It's the only reference in the repo and no wheel matrix builds apy3.13tartifact.Test
Re-ran all four pytorch wheel jobs today with
BUILDER_BRANCH=jechrist/fix-cp313t-missingandFORCE_BUILD_AND_PUSH_MANYLINUX_IMAGE=1. The patched Dockerfile_2_28 now builds and pushesrocm/pytorch-private:manylinux-7.2-compute-rocm-rel-7.2-93cleanly:Companion PR #106 lands the same fix on
main.