Wmma support for gemm_bias_add_reduce - #3316
Merged
Merged
Conversation
EnricoDeg
requested review from
a team,
ThomasNing,
afagaj,
andriy-ca,
aosewski,
asleepzzz,
bartekxk,
carlushuang,
cgmillette,
coderfeli,
geyyer,
illsilin,
poyenc,
qianfengz,
shumway,
tenpercent and
vidyasagar-amd
as code owners
November 27, 2025 09:13
EnricoDeg
marked this pull request as draft
November 27, 2025 09:13
EnricoDeg
marked this pull request as ready for review
November 27, 2025 13:53
krithalith
reviewed
Nov 28, 2025
Contributor
|
In the profiler impl we have: But I thought the Bias was a simple 1D vector of size N? |
wj-laskowski
reviewed
Dec 3, 2025
EnricoDeg
force-pushed
the
streamhpc/gemm_bias_add_reduce_wmma
branch
2 times, most recently
from
December 9, 2025 08:34
7cd0696 to
d7cbde3
Compare
Contributor
Author
Yeah it's wrong. I've fixed it |
EnricoDeg
force-pushed
the
streamhpc/gemm_bias_add_reduce_wmma
branch
2 times, most recently
from
December 12, 2025 12:25
5693d1b to
0c73ab7
Compare
krithalith
self-requested a review
December 12, 2025 16:57
krithalith
previously approved these changes
Dec 12, 2025
EnricoDeg
force-pushed
the
streamhpc/gemm_bias_add_reduce_wmma
branch
4 times, most recently
from
December 23, 2025 09:31
1ef174f to
7eafbda
Compare
EnricoDeg
force-pushed
the
streamhpc/gemm_bias_add_reduce_wmma
branch
from
January 6, 2026 11:13
7eafbda to
ab649a9
Compare
illsilin
approved these changes
Jan 7, 2026
shumway
pushed a commit
that referenced
this pull request
Jan 15, 2026
* Add tests for gemm_bias_add_reduce * Initial working implementation * Generalize implementation of reduce epilogue * Add tests for all layouts * Add instances * Fix test archs * Fix xdl bug * Remove library/profiler duplications * Fix num_byted error profiler * Fix typos * Fix copyright
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Summary:
EpilogueReduceCShuffleto support bias + add operations before reduction (multiple Ds)gemm_bias_add_reduceChecklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered