V5r1 refactor#36
Closed
zjing14 wants to merge 36 commits into
Closed
Conversation
added 28 commits
September 8, 2021 17:16
added 2 commits
October 4, 2021 17:59
asroy
pushed a commit
that referenced
this pull request
Oct 6, 2021
…WD-v4r5 (#36) * experimenting magic number division * overhauling fwd-v4r4 to clearly reflect transformation graph * added fwd-v4r5 * bug fix for make_dynamic_naive_tensor_descriptor_aligned_v2 * bug fix and added sanity-check in transform_dynamic_tensor_descriptor * added conv_driver_v2
asroy
reviewed
Oct 6, 2021
| // experimental implementation | ||
| #ifndef CK_EXPERIMENTAL_USE_BUFFER_LOAD_OOB_CHECK_OFFSET_TRICK | ||
| #define CK_EXPERIMENTAL_USE_BUFFER_LOAD_OOB_CHECK_OFFSET_TRICK 0 | ||
| #define CK_EXPERIMENTAL_USE_BUFFER_LOAD_OOB_CHECK_OFFSET_TRICK 1 |
Contributor
There was a problem hiding this comment.
Why need it, for performance or correctness?
Contributor
Author
There was a problem hiding this comment.
Should it bring us better performance?
asroy
reviewed
Oct 6, 2021
| a_k0_m_k1_grid_desc, | ||
| b_k0_n_k1_grid_desc, | ||
| c_m0_n0_m1_n1_m2_m3_m4_n2_grid_desc, | ||
| c_m0_m1_m2_n_grid_desc, |
Contributor
Author
|
@asroy Updated. Add a separate driver: conv_fwd_driver_offline_nchwc for NCHWC format. Removed data transform inside device function. |
Contributor
Author
|
@asroy Please review the PR again. |
Contributor
Author
|
This PR is included in PR #49 |
carlushuang
pushed a commit
that referenced
this pull request
Mar 26, 2024
Initial MI350 enablement.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.