Conversation
added 30 commits
September 8, 2021 17:16
added 14 commits
October 15, 2021 20:39
zjing14
changed the title
Closed
asroy
reviewed
Nov 15, 2021
| } | ||
| else if constexpr(N == 8) | ||
| { | ||
| #if 0 |
Contributor
There was a problem hiding this comment.
something wrong with llvm_amdgcn_raw_buffer_store_fp16x4?
asroy
suggested changes
Nov 15, 2021
Contributor
asroy
left a comment
asroy
left a comment
There was a problem hiding this comment.
CMakeFiles/device_gemm_instance.dir/__/device_operation/device_gemm_xdl_instance_f32_f32_f32_mk_nk_mn.cpp.o: In function `bfloat16_to_float':
/opt/rocm-4.1.0/hip/include/hip/hcc_detail/hip_vector_types.h:373: multiple definition of `bfloat16_to_float'
CMakeFiles/device_gemm_instance.dir/__/device_operation/device_gemm_xdl_instance_f32_f32_f32_mk_kn_mn.cpp.o:/opt/rocm-4.1.0/hip/include/hip/hcc_detail/hip_vector_types.h:373: first defined here
CMakeFiles/device_gemm_instance.dir/__/device_operation/device_gemm_xdl_instance_f32_f32_f32_mk_nk_mn.cpp.o: In function `size':
/root/workspace/composable_kernel/external/rocm/include/bfloat16_dev.hpp:68: multiple definition of `float_to_bfloat16'
Please fix the build issue for ckProfiler
| // experimental implementation | ||
| #ifndef CK_EXPERIMENTAL_USE_BUFFER_LOAD_OOB_CHECK_OFFSET_TRICK | ||
| #define CK_EXPERIMENTAL_USE_BUFFER_LOAD_OOB_CHECK_OFFSET_TRICK 0 | ||
| #define CK_EXPERIMENTAL_USE_BUFFER_LOAD_OOB_CHECK_OFFSET_TRICK 1 |
Contributor
There was a problem hiding this comment.
Why using this, for correctness issue?
This trick (OOB feature + set offset to > 4GB) should no longer give better performance than the other (OOB feature + set padding element to 0)
Contributor
Author
There was a problem hiding this comment.
Yes. Used this for correctness issue.
7 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.