ci: add gpuagent build workflow and fix abseil linker group#74
Merged
Conversation
…group GNU ld on Ubuntu 24.04 requires explicit archive grouping for circular references between static archives. Without the group brackets the linker emits undefined symbol errors for abseil and gRPC symbols.
Validates every PR and push to main builds gpuagent successfully. Uses the RHEL9 builder container with GHA layer cache to keep repeat runs fast. External contributor PRs require maintainer approval before the workflow runs (configured via repo Settings → Actions → Fork pull request workflows).
spraveenio
added a commit
to ROCm/device-metrics-exporter
that referenced
this pull request
Jul 10, 2026
… upstreamed abseil patch (#553) * [NO-JIRA] chore(gpuagent): bump to main HEAD ad0f7f10, drop upstreamed abseil patch (#1447) * chore(gpuagent): bump to main HEAD ad0f7f10, drop upstreamed abseil patch Advance GPUAGENT_COMMIT from 9af0bf5b → ad0f7f10 (2026-07-10). Commits pulled in: 22ec8211 — abseil --start-group/--end-group linker fix (ROCm/gpu-agent#74) ad0f7f10 — CVE fix: go 1.25.11→1.25.12, x/net v0.55.0, x/sys v0.44.0 (ROCm/gpu-agent#77) Remove patch/gpuagent/0001-abseil-link-start-group.patch — merged upstream in ROCm/gpu-agent#74. 0002-gpuop-907-clock-freq-oob.patch stays (PR #75 still open). Co-Authored-By: Claude <noreply@anthropic.com> * docs: add plan file for gpuagent bump to ad0f7f10 Satisfies the per-PR plan-file CI gate for #1447. Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 6c587757f14987ac70ec3ecc9aac457a5641e948) * Delete docs-internal/knowledge/plans/2026-07-09-gpuagent-bump-ad0f7f10.md --------- Co-authored-by: Praveen Kumar Shanmugam <58961022+spraveenio@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ci.yml: GitHub Actions CI workflow that builds gpuagent on every PR and push tomain, using the RHEL9 builder container with GHA layer cachesw/nic/gpuagent/Makefile: add--start-group/--end-grouparound the gRPC/abseil static archive group, required for GNU ld on Ubuntu 24.04 (the CI runner)Details
CI workflow (
ci.yml):'**'), pushes tomain, andworkflow_dispatchtools/build-container/Dokerfile.rhel9with GHA layer cache to speed up repeat runsmake gpuagentinside the builder container to validate the full buildLinker fix (
sw/nic/gpuagent/Makefile):-Wl,--start-groupbefore-lgrpc++_reflectionand-Wl,--end-groupafter-labsl_flags_parseTest Plan
make gpuagentproducessw/nic/build/x86_64/sim/bin/gpuagentandgpuctl🤖 Generated with Claude Code