Quiet an unused result warning from g++

[derobins]

No description provided.

[derobins]

/home/darobins/ais/hipFile/src/amd_detail/stats.cpp: In destructor ‘hipFile::StatsServer::~StatsServer()’:
/home/darobins/ais/hipFile/src/amd_detail/stats.cpp:112:20: warning: ignoring return value of ‘ssize_t write(int, const void*, size_t)’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  112 |         write(m_efd.get(), &i, sizeof(i));
      |         ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~

[Copilot]

Pull request overview

This PR updates the AMD stats server shutdown path to silence a g++ “unused result” warning when signaling the background thread to exit.

Changes:

• Capture the return value of write() in StatsServer::~StatsServer() using a [[maybe_unused]] variable to quiet compiler warnings.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

write() is used to wake the polling thread so the destructor can join(). If this write() fails (e.g., returns -1 on EINTR), the polling thread may never be notified and the destructor can block indefinitely in join(). Since you now capture the return value, it’d be safer to retry on EINTR and handle hard failures (e.g., by also making threadFn() break on POLLERR/POLLNVAL for the eventfd, or otherwise ensuring the thread is guaranteed to exit).

[derobins]

@zbyrne Is this valid? Does this need a real fix?

[kurtmcmillan]

I vote to fix it.

[zbyrne]

yeah, sounds valid. Shame we aren't using C++20 with jthreads and stop_tokens

[derobins]

Okay, I'm going to close this PR then while @zbyrne implements a real fix