Make StatsServer dtor retry signalling thread to stop.#237
Merged
Conversation
zbyrne
requested review from
derobins,
gaoikawa,
jordan-turbofish,
kurtmcmillan and
riley-dixon
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Improves shutdown robustness of StatsServer by ensuring the background polling thread is reliably signaled to stop, even when the signal write is interrupted.
Changes:
- Retry the
eventfdstop-signalwrite()inStatsServer::~StatsServer()when interrupted byEINTR. - Broaden the thread stop condition to also exit on
POLLERR/POLLNVALevents for theeventfdpoll descriptor.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zbyrne
force-pushed
the
zbyrne/statsserver-dtor
branch
from
c01222c to
337c272
Compare
kurtmcmillan
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix suggested by copilot in #233