[AMDGPU][WaveTransform] Separating SiOptimizeExecMaskingPreRA pass usage for both pipelines. #422
+12
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
both pipelines We enable the SIOptimizeSexecMaskingPreRA pass just before SGPR allocation as planned for waveTransform pipeline, while reverting back to its orginal invocation in the default pipeline.
|
PSDB Build Link: http://mlse-bdc-20dd129:8065/#/builders/10/builds/13 |
cdevadas
reviewed
Oct 29, 2025
|
|
||
| if (OptExecMaskPreRA) | ||
| addPass(&SIOptimizeExecMaskingPreRAID); | ||
| // Optimize EXEC-mask related instructions around SGPR register class. |
There was a problem hiding this comment.
Can you schedule this before the RegisterCoalescer pass, one line above? The coalescer is a prepare for the next SGPR allocation pass. So don't schedule any pass in between.
|
PSDB Build Link: http://mlse-bdc-20dd129:8065/#/builders/10/builds/14 |
vg0204
force-pushed
the
amd/dev/vikashgu/enable-SiOptimizeExecMaskingPreRA-waveTransform-default-pipeline
branch
from
c4bb863 to
997dedf
Compare
|
PSDB Build Link: http://mlse-bdc-20dd129:8065/#/builders/10/builds/15 |
cdevadas
approved these changes
Oct 29, 2025
vg0204
deleted the
amd/dev/vikashgu/enable-SiOptimizeExecMaskingPreRA-waveTransform-default-pipeline
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We enable the SIOptimizeSexecMaskingPreRA pass just before SGPR allocation as planned for waveTransform pipeline, while reverting back to its orginal invocation in the default pipeline.
It is the continuation work on #412 .