Skip to content

Fixing the liveset computation in the epilogue code. #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
cdevadas wants to merge 1 commit into
base: amd-common
Choose a base branch
from
Draft

Fixing the liveset computation in the epilogue code. #161

cdevadas wants to merge 1 commit into from

Conversation

@cdevadas
Copy link

@cdevadas cdevadas commented Jun 24, 2019

Added LiveOut sets to LiveRegs.
Iterated over the instructions in the reverse direction until the insertion point to mark the live registers.

arsenm
arsenm requested changes Jun 24, 2019
View reviewed changes
Copy link

@arsenm arsenm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use LiveRegs.stepBackward instead of manually checking the instruction operands. This is also incorrect since it doesn't check use/def

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arsenm arsenm arsenm requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cdevadas @arsenm