Skip to content

release/2.13 bringup: pin requirements.txt#3445

Merged
jithunnair-amd merged 9 commits into
release/2.13from
pgarayfe/release-2.13-pin-requirements
Jul 21, 2026
Merged

release/2.13 bringup: pin requirements.txt#3445
jithunnair-amd merged 9 commits into
release/2.13from
pgarayfe/release-2.13-pin-requirements

Conversation

@pablo-garay

@pablo-garay pablo-garay commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Summary

Pin Python dependencies for the release/2.13 bringup so CI and builds are reproducible.

  • requirements.txt — pin all direct dev deps (with a python_version split for networkx).
  • requirements-build.txt — pin all build-system deps (with a python_version split for numpy).
  • .ci/docker/requirements-ci.txt — pin the 12 previously-loose entries: click, librosa (<3.11), psutil, pytest-rerunfailures, unittest-xml-reporting, redis, pyzstd (<3.13 / >=3.13), six, tqdm, cuda-bindings, cupti-python, uv. Everything else in the file was already pinned.

Versions were resolved with uv pip compile and verified to resolve cleanly on Python 3.10–3.14.

Tested/Verified:

TESTED on different versions; good enough results (build steps passed + test failures unrelated to changes):
Py3.10: https://github.com/ROCm/TheRock/actions/runs/29779170268/job/88480432450
Py3.11: https://github.com/ROCm/TheRock/actions/runs/29779138751/job/88480277806
Py3.12: https://github.com/ROCm/TheRock/actions/runs/29593825191/job/87929269396
Py3.13: https://github.com/ROCm/TheRock/actions/runs/29779082237/job/88479960891
Py3.14: https://github.com/ROCm/TheRock/actions/runs/29783793885/job/88490775157

@rocm-repo-management-api

rocm-repo-management-api Bot commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Jenkins build for db77a8d1ef918bdd6d9f794ecbdef27438c38468 commit finished as FAILURE
Links: Pipeline Overview / Build artifacts / Test Results

@rocm-repo-management-api

rocm-repo-management-api Bot commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Jenkins build for 7e6e20148a5a62abfba8f80622d0cd5c1b0f9c2a commit finished as NOT_BUILT
Links: Pipeline Overview / Build artifacts / Test Results

@rocm-repo-management-api

rocm-repo-management-api Bot commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Jenkins build for 7e6e20148a5a62abfba8f80622d0cd5c1b0f9c2a commit finished as FAILURE
Links: Pipeline Overview / Build artifacts / Test Results

@rocm-repo-management-api

rocm-repo-management-api Bot commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Jenkins build for cc7053e19dcf530997dde6ff1d5f72b4a071b370 commit finished as FAILURE
Links: Pipeline Overview / Build artifacts / Test Results

@rocm-repo-management-api

rocm-repo-management-api Bot commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Jenkins build for 0bdf6021017b89b9ffd5a340428399f6e32b2f03 commit finished as NOT_BUILT
Links: Pipeline Overview / Build artifacts / Test Results

@rocm-repo-management-api

rocm-repo-management-api Bot commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Jenkins build for 821d306eeffd90843bd654cf50fada711e217bad commit finished as NOT_BUILT
Links: Pipeline Overview / Build artifacts / Test Results

@rocm-repo-management-api

rocm-repo-management-api Bot commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Jenkins build for 821d306eeffd90843bd654cf50fada711e217bad commit finished as FAILURE
Links: Pipeline Overview / Build artifacts / Test Results

Detected error during base docker image building:

#53 523.8 downloading and extracting https://developer.download.nvidia.com/compute/cuda/redist/cuda_cupti/linux-x86_64/cuda_cupti-linux-x86_64-12.8.90-archive.tar.xz ...
#53 523.8 copy /var/lib/jenkins/.triton/nvidia/cupti/cuda_cupti-linux-x86_64-12.8.90-archive/include to /var/lib/jenkins/triton/third_party/nvidia/backend/include ...
#53 523.8 copy /var/lib/jenkins/.triton/nvidia/cupti/cuda_cupti-linux-x86_64-12.8.90-archive/lib to /var/lib/jenkins/triton/third_party/nvidia/backend/lib/cupti ...
#53 523.8 downloading and extracting https://oaitriton.blob.core.windows.net/public/llvm-builds/llvm-ac5dc54d-ubuntu-x64.tar.gz ...
#53 523.8 downloading and extracting https://github.com/nlohmann/json/releases/download/v3.11.3/include.zip ...
#53 523.8 error: <urlopen error _ssl.c:993: The handshake operation timed out>
#53 523.8 
#53 523.8 ERROR Backend subprocess exited when trying to invoke build_wheel
#53 523.8 ERROR conda.cli.main_run:execute(148): `conda run python -m build --wheel --no-isolation` failed. (See above for error)
#53 ERROR: process "/bin/sh -c if [ -n \"${TRITON}\" ]; then bash ./install_triton.sh; fi" did not complete successfully: exit code: 1
------

@jithunnair-amd
jithunnair-amd requested a review from ethanwee1 July 16, 2026 13:42
@jithunnair-amd

jithunnair-amd commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

@pablo-garay Thanks for the PR. I would suggest we kick off builds on theRock CI for all python versions, so we can get a signal on how the build and core tests do with this pinning logic. @ethanwee1 can provide you more info on how to do that.

@pablo-garay
release/2.13: pin requirements.txt
f4f9dad 
Pin requirements.txt to the same versions used on release/2.12 (identical
package set; optree kept split on python_version 3.14 as in 2.12).

Signed-off-by: pablo-garay <pgarayfe@amd.com>
@pablo-garay
release/2.13: pin requirements-build.txt and update requirements.txt …
ebbe27e 
…pins

Pin build-system deps in requirements-build.txt and set the direct
requirements.txt pins to the versions selected for the 2.13 release.
build keeps the [uv] extra (build[uv]==1.5.0).

Signed-off-by: pablo-garay <pgarayfe@amd.com>
@pablo-garay
release/2.13: bump setuptools and numpy pins in requirements-build.txt
3cc19d5 
setuptools==81.0.0 and numpy==2.5.1.

Signed-off-by: pablo-garay <pgarayfe@amd.com>
@pablo-garay
release/2.13: restore full pip comment in requirements-build.txt
2214d42 
Signed-off-by: pablo-garay <pgarayfe@amd.com>
@pablo-garay
release/2.13: split networkx and numpy pins by python_version
d7549b8 
networkx 3.4.2 (<3.11) / 3.6.1 (>=3.11) in requirements.txt;
numpy 2.2.6 (<3.11) / 2.4.6 (==3.11) / 2.5.1 (>=3.12) in requirements-build.txt.

Signed-off-by: pablo-garay <pgarayfe@amd.com>
@pablo-garay
release/2.13: pin loose entries in .ci/docker/requirements-ci.txt
836cf99 
Pin the previously-loose entries to resolved versions (verified via uv pip
compile on py3.10-3.14): click, librosa (<3.11), psutil, pytest-rerunfailures,
unittest-xml-reporting, redis, pyzstd (split <3.13/>=3.13), six, tqdm,
cuda-bindings, uv.

Signed-off-by: pablo-garay <pgarayfe@amd.com>
@pablo-garay
release/2.13: pin cupti-python in .ci/docker/requirements-ci.txt
932a374 
cupti-python==13.3.0 (resolved uniform across py3.10-3.13; absent on 3.14 per
existing marker). Marker/comment preserved.

Signed-off-by: pablo-garay <pgarayfe@amd.com>
@pablo-garay
release/2.13: keep cuda-bindings as >=13.0,<14.0 range
c4dc10e 
Revert the cuda-bindings hard pin back to the upstream range so it matches the
accompanying comment (allow minor updates within the CUDA 13 major).

Signed-off-by: pablo-garay <pgarayfe@amd.com>
@pablo-garay
pablo-garay force-pushed the pgarayfe/release-2.13-pin-requirements branch from 821d306 to c4dc10e Compare July 20, 2026 19:25
@rocm-repo-management-api

rocm-repo-management-api Bot commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Jenkins build for 7bec22985731d62949ba36ea672f1108a9d76939 commit finished as NOT_BUILT
Links: Pipeline Overview / Build artifacts / Test Results

@pablo-garay
release/2.13: skip fbscribelogger on Python 3.14
7bec229 
fbscribelogger==0.1.7 caps thriftpy2<0.6.0, and thriftpy2 only ships cp314 wheels from 0.6.0. On Python 3.14 pip therefore source-builds thriftpy2 via distutils/gcc, which fails in the compiler-less test image (no_rocm_image_ubuntu24_04). fbscribelogger is a no-op on OSS/ROCm CI, so gate it to python_version < 3.14.

Signed-off-by: pablo-garay <pgarayfe@amd.com>
@rocm-repo-management-api

rocm-repo-management-api Bot commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Jenkins build for 7bec22985731d62949ba36ea672f1108a9d76939 commit finished as FAILURE
Links: Pipeline Overview / Build artifacts / Test Results

@pablo-garay

pablo-garay commented Jul 21, 2026

Copy link
Copy Markdown
Author

@pablo-garay Thanks for the PR. I would suggest we kick off builds on theRock CI for all python versions, so we can get a signal on how the build and core tests do with this pinning logic. @ethanwee1 can provide you more info on how to do that.

done ; PTAL @ PR description

@jithunnair-amd
jithunnair-amd merged commit a6ab526 into release/2.13 Jul 21, 2026
3 of 5 checks passed
@jithunnair-amd
jithunnair-amd deleted the pgarayfe/release-2.13-pin-requirements branch July 21, 2026 01:58
@pablo-garay pablo-garay mentioned this pull request Jul 25, 2026
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanwee1 ethanwee1 Awaiting requested review from ethanwee1
@jithunnair-amd jithunnair-amd Awaiting requested review from jithunnair-amd

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pablo-garay @jithunnair-amd