Fix rocDecode test#480
Open
daniellegillai wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the failing video_tests_rocdecode CTest by aligning the test arguments and decoder selection logic with the documented hardware_decode_mode=0/1 contract, preventing mismatched decode configuration that could lead to hangs/timeouts.
Changes:
- Update
video_tests_rocdecodeCTest to passhardware_decode_mode=1(valid value) instead of2. - Make
video_tests.cppconsistently treatdecoder_type == 1as the only condition for HW/rocDecode mode.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/cpp_api/video_tests/video_tests.cpp | Makes HW decode mode selection consistent by checking decoder_type == 1. |
| tests/cpp_api/CMakeLists.txt | Fixes the rocDecode CTest argument to use a valid hardware_decode_mode value. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+133
to
136
| auto decoder_mode = ((decoder_type == 1) ? RocalDecodeDevice::ROCAL_HW_DECODE : RocalDecodeDevice::ROCAL_SW_DECODE); | ||
| RocalDecoderType rocal_decoder_type = RocalDecoderType::ROCAL_DECODER_VIDEO_FFMPEG_SW; | ||
| if (decoder_type == 1) { | ||
| rocal_decoder_type = RocalDecoderType::ROCAL_DECODER_VIDEO_ROCDECODE; |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #479 so that the video_tests_rocdecode ctest passes.
Technical Details
Pass in 1 as the hardware_decode_mode arg for video_tests.cpp (instead of 2), and also change video_tests.cpp to consistently check if the decoder_type == 1, rather than == 1 in one check and > 0 in another.
Test Plan
rocAL ctests.
Test Result
All 21 ctests pass.