[AIROCMLIR-564] Lower migraphx.reshape using helper function#2271
Merged
[AIROCMLIR-564] Lower migraphx.reshape using helper function#2271
migraphx.reshape using helper function#2271Conversation
Mr-Anyone
requested review from
dhernandez0,
justinrosner,
pabloantoniom and
umangyadav
umangyadav
approved these changes
Mar 6, 2026
Mr-Anyone
force-pushed
the
pr-migraphx-to-linalg-broadcasting
branch
from
027e966 to
fd730d0
Compare
Mr-Anyone
force-pushed
the
pr-migraphx-to-linalg-reshape
branch
from
d3bd904 to
3f78e53
Compare
cursor Bot
pushed a commit
that referenced
this pull request
Mar 13, 2026
Automated weekly review of merged PRs #2234 #2240 #2248 #2249 #2251 #2254 #2257 #2258 #2259 #2270 #2271. Identifies 6 areas with weak test coverage and meaningful business risk: 1. ConcurrentQueue (no unit tests, multi-threaded, silent deadlock risk) 2. parse_tuning_db_line / read_tuning_db key schema change (no Python tests) 3. BooleanElementwiseConverter missing f16/unsigned dtype coverage 4. Attention MaxNumFOp vs MaximumFOp NaN correctness (no dedicated test) 5. firstCausalMaskIter off-by-one risk (no non-trivial shape test) 6. Sliding window attention edge cases (windowSize=0/>=seqLen/unaligned) The GitHub discussion API returned FORBIDDEN (read-only CI token); analysis committed here as a permanent record. Co-authored-by: Djordje Antic <djordje.antic@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Being able to lower
migraphx.reshapeTechnical Details
migraphx.reshape is lowered as the following:
This is kind of a freebie from the previous PR as that PR implemented
reshapeValuefunctionNote that the tosa pipeline lowers
tosa.reshapeas a expand_shape and collapse_shape as well. This is done in thetosa-to-tensorpass::https://github.com/llvm/llvm-project/blob/42d07c38e22768360a66548407a28332340efb20/mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp#L259-L261
Test Plan
lit test
Test Result
Passed lit test
Submission Checklist