Closed
Conversation
Contributor
lawruble13
commented
Jun 15, 2021
lawruble13
commented
- Build GTest and GBench statically
- Create packages for each of "examples", "tests", and "benchmarks"
- Set package dependencies appropriately
lawruble13
added
the
noCI
saadrahim
reviewed
Jun 15, 2021
| @@ -79,7 +79,7 @@ while true; do | |||
| shift ;; | |||
| -c|--clients) | |||
| build_clients=true | |||
Member
There was a problem hiding this comment.
change build_clients to build_tests? Let's standardize the names to reflect the package names we choose.
saadrahim
reviewed
Jun 15, 2021
| build_clients=true | ||
| build_benchmarks=true | ||
| build_benchmark=true | ||
| shift ;; |
Member
There was a problem hiding this comment.
might want to add a build_examples
Contributor
Author
|
Superceded by #256. |
ammallya
pushed a commit
that referenced
this pull request
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.