[rmake][rtest][rocPRIM] Update rmake and rtest #654
Closed
NguyenNhuDi wants to merge 20 commits intoROCm:developfrom
Closed
[rmake][rtest][rocPRIM] Update rmake and rtest #654NguyenNhuDi wants to merge 20 commits intoROCm:developfrom
NguyenNhuDi wants to merge 20 commits intoROCm:developfrom
Conversation
NguyenNhuDi
requested review from
RobsonRLemos,
lawruble13,
stanleytsang-amd and
umfranzw
as code owners
NguyenNhuDi
changed the base branch from
develop
to
release-staging/rocm-rel-6.4
stanleytsang-amd
approved these changes
Nov 28, 2024
spolifroni-amd
approved these changes
Dec 2, 2024
NguyenNhuDi
changed the base branch from
release-staging/rocm-rel-6.4
to
develop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating rmake and rtest to be more consistent with its code.
Separating Linux and Windows implementation more clearly for better future debugging. While maintain coding style between the two systems for more consistency.
This PR is not finished, and only rmake is implemented. Making a PR so that I can use CI to test for any missing support