Add workaround for printing 128-bit types in gtest for windows#708
Conversation
stanleytsang-amd
requested review from
RobsonRLemos,
lawruble13 and
umfranzw
as code owners
|
I'm kind of confused why this workaround is suddenly required now. We were previously able to fully enable 128-bit integers in Windows and we observe no failures in our Windows CI, see b57e163. If you are seeing failures on your side, then perhaps we are both using different versions of the Windows SDK or MSVC compiler? It would be nice to know what those are so that we can use the same configuration on our CI. |
I'm not entirely sure either, we did not see the problem initially with our CI but it has now come up in our CI and also in staging, and also a compiler dev reported it as well. With the compiler dev's machine, I was able to resolve it by #706 , but that does not seem to work elsewhere. The reason I made this PR is because my local Windows machine does not exhibit this issue and I have limited ability to modify/update it at the moment, so I've been clumsily working via this PR. Clearly it must be due to a difference in the HIP SDK build or the compiler version, as you stated. I will try to get that info. Unfortunately due to my limited understanding of the test assertion framework for rocPRIM, I've been unable to fix the problem - I'm clearly missing certain test cases/logic in the assertion code. @Snektron @Naraenda until I can nail down the exact HIP SDK build/compiler version, can you do a quick review and see what I'm missing? test_block_radix_sort fails to compile at the minimum. For a certainty it is related to 128-bit integers as my latest commit to disable them entirely in the unit testing causes the build to succeed (although it seemed to have hung at device_select...) |
|
Can you send us the build error (or entire log)? Either here or via e-mail. We can try narrowing it down on our side. |
| if (test_utils::is_int128<T>::value || test_utils::is_uint128<T>::value || (typeid(T) == typeid(common::custom_type<double,double,1>))) | ||
| { | ||
| const bool values_equal = (result[i] == expected[i]); | ||
| ASSERT_EQ(values_equal, true) << "where index = " << i; |
There was a problem hiding this comment.
Not a biggie but could also use
ASSERT_TRUE(values_equal)
* Add workaround for printing 128-bit types in gtest for windows * Update fix * Disable all 128 bit tests * Add workaround to more assert_eq overloads * Fix tabs [ROCm/rocPRIM commit: fa4811e]
4 participants
See ROCm/hipCUB#462.