Skip to content

build(deps): pin release Rust toolchain action - #137

Merged
rominf merged 1 commit into
mainfrom
chore/pin-release-rust-toolchain
Jul 21, 2026
Merged

build(deps): pin release Rust toolchain action#137
rominf merged 1 commit into
mainfrom
chore/pin-release-rust-toolchain

Conversation

@rominf

@rominf rominf commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Pin the release workflow's Rust toolchain setup action to the full commit SHA for v1.17.0.
  • Replace the moving @v1 tag to align the release workflow with the repository's GitHub Actions supply-chain policy and its other toolchain setup steps.
  • Risk: low — this preserves the action version already used elsewhere and changes only dependency resolution from a moving tag to an immutable commit.

This addresses the follow-up concern identified during review of #120.

Test plan

  • Verified upstream tag v1.17.0 resolves to 166cdcfd11aee3cb47222f9ddb555ce30ddb9659.
  • Ran the configured pre-commit checks for .github/workflows/release.yml, including YAML validation.
  • Confirmed no actions-rust-lang/setup-rust-toolchain@v1 moving-tag references remain in .github/workflows.
  • Confirmed the pre-push signature and DCO checks pass.

Signed-off-by: Roman Inflianskas <Roman.Inflianskas@amd.com>
@rominf
rominf requested review from fredespi and volen-silo July 21, 2026 12:01
@volen-silo

Copy link
Copy Markdown
Collaborator

Review — LGTM ✅

Reviewed the single-line pin of actions-rust-lang/setup-rust-toolchain in release.yml. Independently verified all three test-plan claims:

  • SHA correctnessv1.17.0 is a lightweight tag pointing directly at commit 166cdcfd11aee3cb47222f9ddb555ce30ddb9659 (confirmed via the upstream Git refs API). The pinned SHA is an exact match.
  • Consistency — the @<sha> # v1.17.0 form matches all 16 other setup-rust-toolchain references already pinned across ci.yml, nightly.yml, demo-gifs.yml, and release.yml.
  • Completeness — on main, release.yml:39 was the only remaining moving @vN tag in the whole .github/workflows/ tree. This PR pins the last one, so after merge there are zero moving-tag action references. actions/checkout is already fully pinned.

Scope is tight, description is accurate, low risk. No changes requested.

@rominf
rominf added this pull request to the merge queue Jul 21, 2026
Merged via the queue into main with commit 5c81409 Jul 21, 2026
19 of 20 checks passed
@rominf
rominf deleted the chore/pin-release-rust-toolchain branch July 21, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants