[CMake]: Replace CMAKE_SOURCE_DIR -> RPP_SOURCE_DIR#672
Conversation
|
For future reference in this project. Please avoid using variables such as Prefer to use the relative variants: |
There was a problem hiding this comment.
Pull request overview
This pull request addresses a CMake configuration issue to properly support RPP being used as a subproject in other CMake projects. The changes replace CMAKE_SOURCE_DIR with RPP_SOURCE_DIR to ensure correct path resolution.
Changes:
- Replaced all instances of
CMAKE_SOURCE_DIRwithRPP_SOURCE_DIRin src/modules/CMakeLists.txt to ensure proper relative path resolution when RPP is used as a subproject
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #672 +/- ##
========================================
Coverage 92.69% 92.69%
========================================
Files 196 196
Lines 87559 87559
========================================
+ Hits 81156 81158 +2
+ Misses 6403 6401 -2 🚀 New features to boost your workflow:
|
PR Description:
CMAKE_SOURCE_DIRwithRPP_SOURCE_DIRto properly refer to the relative source directory for RPP.