build: compile OpenPMIx from source for MPI plugin in Dockerfile - #602
Merged
Conversation
AlmaLinux 8 has no openpmix-devel package and distro pmix-devel is 2.x, below pmix_min_version. Build OpenPMIx 5.0.3 during the builder stage when BUILD_MPI_PLUGIN=1 so nightly and release tarballs include a functional spur_mpi_pmix.so.
sgopinath1
requested review from
powderluv,
sajmera-pensando,
shiv-tyagi and
yansun1996
as code owners
August 9, 2026 11:00
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Docker image builds (nightly/release dist target) when BUILD_MPI_PLUGIN=1 by building OpenPMIx from source on AlmaLinux 8, since the distro-provided PMIx packages are either unavailable (openpmix-devel) or too old (pmix-devel 2.x) for Spur’s minimum supported PMIx version.
Changes:
- Adds
OPENPMIX_VERSIONbuild arg and documents why OpenPMIx must be built from source on AlmaLinux 8. - Enables PowerTools and installs build dependencies needed to compile and install OpenPMIx to
/usr/local. - Builds
spur-mpi-pmixwithPKG_CONFIG_PATHpointing at the installed OpenPMIx pkg-config metadata.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #602 +/- ##
==========================================
+ Coverage 76.32% 76.48% +0.16%
==========================================
Files 166 167 +1
Lines 65511 67824 +2313
==========================================
+ Hits 49999 51871 +1872
- Misses 15512 15953 +441 🚀 New features to boost your workflow:
|
Address Copilot review on PR ROCm#602: install pkgconf-pkg-config and tar explicitly for the MPI plugin build, and fetch the OpenPMIx source archive to a temp file before extraction.
yansun1996
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nightly and release builds with
BUILD_MPI_PLUGIN=1fail in the Docker builder because AlmaLinux 8 has noopenpmix-develpackage. The distropmix-develRPM (PowerTools) ships PMIx 2.2.x, which is below Spur'spmix_min_version(4.1.0).This change builds OpenPMIx 5.0.3 from source in the AlmaLinux 8 builder stage when
BUILD_MPI_PLUGIN=1, then compilesspur-mpi-pmixagainst the installedpkg-configmetadata. Nightly/release tarballs can include a functionallib/spur/spur_mpi_pmix.soagain.Approach
OPENPMIX_VERSIONbuild arg (default5.0.3).hwloc-devel,libevent-devel,python3, etc.)./usr/local, runldconfig, thencargo build -p spur-mpi-pmixwithPKG_CONFIG_PATHset.cd /buildbefore the cargo step so removing the OpenPMIx source tree does not leave the shell in a deleted directory.No changes to
spur-ci-infra— nightly/release build entirely inside this Dockerfile on GitHub-hosted runners.Test plan
dist/lib/spur/spur_mpi_pmix.sois producedspur,spurctld,spurd,spur-k8s-operatorindist/bin/(GLIBC_2.28)