Conversation
Owner
Author
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Pull request overview
依存関係を最新化しつつ、TypeScript 6 への移行・ESLint 10 の flat config 化・GitHub Actions の SHA pin・Node/pnpm の要求バージョン引き上げをまとめて行うPRです(フロントエンド資産のビルド/静的解析/CI の足回り更新)。
Changes:
- TypeScript 6 対応のため
tsconfig.jsonを調整(ignoreDeprecations/rootDir追加) - ESLint を ESLint 10 + flat config(
eslint.config.mjs)へ移行し、関連devDependenciesを更新(typescript-eslint統合パッケージ採用) - GitHub Actions をコミットSHAでpinし、CI上の Node/pnpm バージョンも更新
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | TypeScript 6 移行に伴うオプション追加(deprecation抑制、rootDir明示) |
| package.json | engines更新(Node 24.16.0 / pnpm 11.1.2)と ESLint/TS 系devDependencies更新、旧 eslintConfig ブロック削除 |
| pnpm-lock.yaml | 依存関係最新化の反映(ESLint 10/TS6/周辺ツール更新) |
| eslint.config.mjs | ESLint flat config を新規追加し、TS/Prettier/Globals 設定を集約 |
| .github/workflows/deploy.yml | Node/pnpm更新と、Actions の SHA pin 反映 |
| .github/workflows/dependency-review.yml | Node/pnpm更新と、Actions の SHA pin 反映 |
| .github/workflows/stale-issues-and-pullrequests.yml | Actions の SHA pin 反映 |
| .github/workflows/synthetic-monitoring.yml | Actions の SHA pin 反映 |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
期待する挙動・状態
pnpm run buildがエラー無く通るeslint.config.mjs) で動作する.husky/pre-commit) →lint-staged→ eslint + prettier の lint チェーンが実機で機能する必要な依存関係
>=24.16.0>=11.1.2(Node 24.16.0 同梱の corepack 0.35.0 が pin している default)@eslint/js@^10.0.1/typescript-eslint@^8.59.4/globals@^17.6.0/eslint@^10.4.0@typescript-eslint/eslint-plugin(typescript-eslint統合パッケージへ置き換え)確認済み項目
corepack pnpm install成功corepack pnpm run build(tsc -b)成功corepack pnpm exec eslint .exit=0(flat config 動作確認)rhysd/actionlint:1.7.4による全 workflow 検証 pass (exit=0)owner/repo@<40桁SHA> # <タグ>形式で pin 済ignoreDeprecations: "6.0"とrootDir: "./src/ts"を追加し TypeScript 6 のビルドエラーを解消見てほしいところ
ignoreDeprecations: "6.0"/rootDir: "./src/ts")の方針lint-staged 16 → 17のメジャー更新@typescript-eslint/eslint-pluginを統合パッケージtypescript-eslintに置き換えた点eslintConfigブロックからeslint.config.mjs(flat config) に移行した点