Skip to content

fix: harden external protocol handling and unblock dev:electron#4863

Merged
DIYgod merged 2 commits intodevfrom
DIYgod/fix-security-canvas
Feb 20, 2026
Merged

fix: harden external protocol handling and unblock dev:electron#4863
DIYgod merged 2 commits intodevfrom
DIYgod/fix-security-canvas

Conversation

@DIYgod
Copy link
Member

@DIYgod DIYgod commented Feb 20, 2026

Description

  • Harden desktop external URL handling by validating URLs, blocking ignored protocols, and requiring confirmation before opening non-HTTP(S) external schemes.
  • Keep normal HTTP/HTTPS external opening behavior while preventing unsafe window.open flows tied to the security advisory.
  • Fix pnpm dev:electron startup errors by switching to linkedom/worker and aliasing utf-8-validate to a local shim for main-process bundling.

PR Type

  • Feature
  • Bugfix
  • Hotfix
  • Other (please describe):

Screenshots (if UI change)

N/A

Demo Video (if new feature)

N/A

Linked Issues

Additional context

  • Validation run in this workspace: typecheck, lint:fix (warnings only), test, and dev:electron startup.

Changelog

  • I have updated the changelog/next.md with my changes.

@safedep
Copy link

safedep bot commented Feb 20, 2026

SafeDep Report Summary

Green Malicious Packages Badge Green Vulnerable Packages Badge Green Risky License Badge

No dependency changes detected. Nothing to scan.

This report is generated by SafeDep Github App

@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@DIYgod DIYgod merged commit b465ec1 into dev Feb 20, 2026
11 checks passed
@DIYgod DIYgod deleted the DIYgod/fix-security-canvas branch February 20, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant