Skip to content

feat(mobile): align upgrade prompts with desktop#4914

Merged
DIYgod merged 1 commit intodevfrom
codex/mobile-subscription-upgrade-prompts
Mar 12, 2026
Merged

feat(mobile): align upgrade prompts with desktop#4914
DIYgod merged 1 commit intodevfrom
codex/mobile-subscription-upgrade-prompts

Conversation

@DIYgod
Copy link
Member

@DIYgod DIYgod commented Mar 12, 2026

Summary

  • align mobile 402 upgrade handling with desktop for subscription, list, and import flows
  • keep translation limits silent while showing summary upgrade state inline in the AI Summary card
  • sync plan copy and CTA rendering with backend payment config

Testing

  • pnpm --dir apps/mobile run typecheck
  • pnpm --dir packages/internal/store run typecheck
  • pnpm exec eslint apps/mobile/src/App.tsx apps/mobile/src/lib/error-parser.ts apps/mobile/src/modules/feed/FollowFeed.tsx apps/mobile/src/modules/list/FollowList.tsx apps/mobile/src/modules/settings/routes/ManageList.tsx apps/mobile/src/modules/settings/routes/Plan.tsx apps/mobile/src/modules/settings/utils.ts 'apps/mobile/src/screens/(modal)/ListScreen.tsx' packages/internal/store/src/modules/summary/store.ts
  • pnpm --dir apps/mobile run e2e:doctor
  • local follow-server + iOS simulator self-test for subscription-limit modal and summary inline upgrade card

Screenshots

  • Subscription limit modal: /tmp/folo-subscription-limit-prompt.png
  • Summary inline upgrade card: /tmp/folo-summary-current.png
  • Plan screen: /tmp/folo-plan-screen.png
  • Plan lower section: /tmp/folo-plan-screen-lower.png

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: deb7e2477b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +181 to +182
if (!summary.data) {
throw new FollowAPIError("AI summary limit exceeded. Please try again later.", 402)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Distinguish empty summaries from quota failures

SummaryResponse is string | null, but this guard uses a falsy check, so a valid empty-string summary ("") is treated as a payment-limit failure and converted into a synthetic 402 error. In that case the UI will incorrectly show an upgrade-required state (and mark generation as error) instead of handling the response as an empty summary. Restrict this branch to null/undefined (for example summary.data == null) so only missing payloads trigger the upgrade path.

Useful? React with 👍 / 👎.

@DIYgod DIYgod merged commit 3947302 into dev Mar 12, 2026
12 checks passed
@DIYgod DIYgod deleted the codex/mobile-subscription-upgrade-prompts branch March 12, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant