release/node/v0.5.2#113
Merged
Merged
Conversation
Fix two-step broadcast neighbour count for two-step broadcasts
TVM stack slice TL-serialization fix
Changes for release node/v0.5.2
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets two areas: (1) correctness of TVM stack TL-serialization for Slice values (notably preserving bit-length/window), and (2) optimizing fast-sync overlay behavior when QUIC/two-step broadcast is enabled.
Changes:
- Serialize TVM stack
Sliceitems as a BOC-encoded cell (and decode accordingly) to preserve exact slice bit semantics. - Extend semiprivate overlay membership inputs to include both validator ADNL IDs and validator signing public-key IDs, with an optional QUIC mode and two-step broadcast support for fast-sync.
- Add regression tests for slice roundtrips and update overlay tests/call sites for the new semiprivate overlay API.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/vm/src/smart_contract_info.rs |
Switch slice stack encoding/decoding to BOC cell roundtrip to preserve slice semantics. |
src/vm/src/tests/test_smart_contract_info.rs |
Add regression tests validating slice roundtrip preserves bit-length and slice window. |
src/node/src/rpc_server/token.rs |
Accept BOC-encoded slice stack entries when parsing MsgAddress from stack. |
src/node/src/network/overlay_client.rs |
Update semiprivate overlay creation signature and add a two-step broadcast wrapper. |
src/node/src/network/full_node_overlays.rs |
Use prev/this/next validator sets for fast-sync roots and wire use_quic flags into overlay creation/sending. |
src/node/src/network/fast_sync_overlay_client.rs |
Pass ADNL IDs + signing public keys to semiprivate overlays; add two-step broadcast path gated by QUIC availability. |
src/adnl/tests/test_overlay.rs |
Update semiprivate overlay tests to pass both root ADNL IDs and root public keys, plus use_quic. |
src/adnl/src/overlay/mod.rs |
Expand CertifiedMembers overlay structure, QUIC gating, and twostep neighbour selection/counting logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cleverfox
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
Optimized fast-sync overlay operation over QUIC
Fixed
TVM stack slice TL-serialization fix for LiteServer