Cut phantom // rafter-ignore from the rafter skill triage doc - #162
Merged
Conversation
`// rafter-ignore` is only implemented in the VS Code extension, not the CLI scanner — so an agent reading the rafter skill's triage guide would try it on a `rafter scan` / `rafter run` and it'd silently do nothing. Replace it with the real CLI suppression mechanism: a `.rafter.yml` `ignore:` rule (paths / rules / reason), with a note to match on the rule name not the R- id, and the `_suppressed[]` + exit-code behavior. Baseline guidance corrected to `baseline create` + `scan --baseline`. Links to docs.rafter.so/suppression. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Verified against the scanner: the rule is emitted as "AWS Access Key ID"; "AWS Access Key" matches nothing and would silently suppress zero findings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/finding-triage.md(node + python skill copies) told agents to suppress findings with// rafter-ignore: …. That comment is only implemented in the VS Code extension (vscode/src/secret-scanner.ts) — the CLI scanner andrafter rundon't honor it, so an agent following the triage guide would try it and it'd silently do nothing.Replaces it with the real CLI suppression mechanism:
.rafter.ymlignore:rule (paths/rules/reason),ruleson the rule name, not the hashedR-…PR-comment id,_suppressed[]+ exit-code behavior on local scans,rafter agent baseline create+rafter scan --baseline,Verified against the CLI source + the existing suppression/policy/baseline tests (all pass). Docs-only change.
🤖 Generated with Claude Code